Conversation
|
Why delete this one? The other one does less error handling. |
|
Logout shouldn't fail. This one silently succeeds always and I believe that to be the correct approach. |
|
No the other one doesn't silently succeed if, for example, the database can't be reached. |
|
@gfosco updated the pull request. |
|
Cool. I would like to see some tests for this one as it's a security issue. (imagine a user logs thinks they have logged out from a public computer, but really the next person to use the computer can still log in as them) Hopefully we can avoid having to make any CVEs for quite awhile :) |
|
@gfosco updated the pull request. |
|
Yay passing tests! |
|
We're observing this code now always deleting the most recently created _Session. How do we call Parse.User.logout() and specify which session we want to delete? |
|
@woodardj were you able to figure it out? I'm having the same problem |
No description provided.