Add ability to create classes without creating an object.#267
Closed
drew-gross wants to merge 23 commits intoparse-community:masterfrom
drew-gross:Schema-expose-failure
Closed
Add ability to create classes without creating an object.#267drew-gross wants to merge 23 commits intoparse-community:masterfrom drew-gross:Schema-expose-failure
drew-gross wants to merge 23 commits intoparse-community:masterfrom
drew-gross:Schema-expose-failure
Conversation
the race loser return before the race winner. This test failed in mongo 2.6.11, and I don't know if thats because it's generally flaky or if that version of mongo makes less guarantees.
|
@drew-gross updated the pull request. |
Schema.js
Outdated
| className === '_SCHEMA' || //TODO: remove this, as _SCHEMA is not a valid class name for storing Parse Objects. | ||
| className === '_Role' || | ||
| joinClassRegex.test(className) || | ||
| classAndFieldRegex.test(className) |
Contributor
There was a problem hiding this comment.
why not use fieldNameIsValid()
Contributor
Author
There was a problem hiding this comment.
This is to support legacy callers. The legacy callers should be updated, but that will have to come in a later PR.
Contributor
Author
There was a problem hiding this comment.
Oops, I misunderstood your original comment, GitHub was highlighting line 76 so I thought you were just talking about that line. Replacing this with fieldNameIsValid is actually a good idea, I will do that and the other change and then merge this. Thanks for the review!
Contributor
|
@drew-gross reviewed what I could. |
This will encode all ParseObject on the correct way so they can be translated into PFObject by the IOS SDK.
Thought it would be helpful to expose the example. It feels hidden in the docs right now.
If there is a default master key, people will inevitably use it. And that would be bad.
|
@drew-gross updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
Contributor
Author
|
Hmmm this PR now includes a bunch of random commits somehow. I'm going to close this and make a new one. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful for schemas API POST.