Makes sure pointer includes are interpolated as get#2747
Merged
flovilmart merged 3 commits intomasterfrom Sep 24, 2016
Merged
Conversation
ghost
added
the
flovilmart
changed the title
drew-gross
approved these changes
Sep 24, 2016
Contributor
drew-gross
left a comment
drew-gross
left a comment
There was a problem hiding this comment.
Just one comment otherwise looks good
| sort = {}, | ||
| count, | ||
| } = {}) { | ||
| } = {}, op) { |
Contributor
There was a problem hiding this comment.
Can you put this parameter in the options arg instead?
Contributor
Author
There was a problem hiding this comment.
yep definitely :)
flovilmart
force-pushed
the
issue-#2005
branch
from
522d44f to
7dec71a
Compare
|
@flovilmart updated the pull request - view changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the $in query for the includes be interpolated as a get to pass through the CLP preferences (as it's a series of get that's optimized as a $in)
Fixes #2005