support pg-promise init options

[rendongsc]

add database init options , hook pg connect.

var api = new ParseServer({
  databaseURI: databaseUri || 'postgres://Test:123@localhost:5432/Test',
  appId: process.env.APP_ID || 'myAppId',
  masterKey: process.env.MASTER_KEY || '',
  serverURL: process.env.SERVER_URL || 'http://localhost:1337/parse', 
  databaseOptions: {
    initOptions: {
      connect: function (client, dc, isFresh) {
        //do something here 
      }
    }
  }
});

[flovilmart]

@rendongsc can you fix the lint issue and add tests to make sure we don't incur any regression?

[vitaly-t]

As the author of pg-promise, I must say this looks wrong to me...

 client.pg.defaults[key] = dbOptions.pgOptions[key];

Variable client is the database object, which doesn't have property pg. Only the library's initialized object has it:

pgp.pg.defaults[key] = dbOptions.pgOptions[key];

So I presume this simply has never been tested, or else it would throw an error.

[flovilmart]

@vitaly-t what do you recommend. Could you have a look if there's anything wrong there?

[vitaly-t]

I have, and I published right there what it should be ;)

pgp.pg.defaults[key] = dbOptions.pgOptions[key];

[flovilmart]

@vitaly-t got time for a PR? Who better than you? Should I close that one? Also, I believe with the amount of contributions you have, you should probably be granted commit access. Are you interested?

[vitaly-t]

I'm not sure what this PR is really doing, but there issue that I described was there before.

There's only that one change is needed ;) I do not have rights to update the PR, you can do it ;)

[flovilmart]

Just open a new one in that case, closing :)

[rendongsc]

@vitaly-t

pgp.pg.defaults[key] = dbOptions.pgOptions[key];

Not wrong, but does not work.

var api = new ParseServer({
  databaseURI: databaseUri || 'postgres://Test:123@localhost:5432/Test',
  cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
  appId: process.env.APP_ID || 'myAppId',
  masterKey: process.env.MASTER_KEY || '', 
  serverURL: process.env.SERVER_URL || 'http://localhost:1337/parse',  
  liveQuery: {
    classNames: ["Posts", "Comments"] 
  },
  databaseOptions: {
    pgOptions: {
      connect: function (client, dc, isFresh) {
        if (isFresh) {          
          client.query('SET search_path = cust');
        }
      }
    }
  }
});

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[flovilmart]

Could you add a test for that?

[rendongsc]

@flovilmart I test the way through the output log, and spec test specifications vary greatly, give me some time.

[flovilmart]

Perhaps a mock and expectations of call for example

[flovilmart]

@rendongsc did you get a chance to add some tests?

[rendongsc]

@flovilmart I can do that.

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[flovilmart]

@rendongsc thanks for adding the tests, it seems that the linter is complaining about your spec files

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[facebook-github-bot]

@rendongsc updated the pull request - view changes

[flovilmart]

@rendongsc Thanks for the PR!