Fixes #3717#3824
Fixes #3717#3824flovilmart merged 3 commits intoparse-community:masterfrom felipeandradebezerra:master
Conversation
|
Can you address the lint issues?
|
|
We should also probably add a test for that just in case it ends up in production :) |
|
Kkkkkk... Lint?! How can I check that? |
|
Running |
Add a test to check push_time format and if it should schedule push when the parse-server is configured
|
I'm getting used to work with parse-server :-) |
|
HI @flovilmart Did I miss anything? :-) |
Codecov Report
@@ Coverage Diff @@
## master #3824 +/- ##
==========================================
+ Coverage 90.16% 90.17% +0.01%
==========================================
Files 114 114
Lines 7532 7534 +2
==========================================
+ Hits 6791 6794 +3
+ Misses 741 740 -1
Continue to review full report at Codecov.
|
|
Looking good, it is working well for you? |
|
@flovilmart I think it is, will double check. Anyway, I sent you an email early this week with some questions concerning running and testing parse-server. |
|
Yes! I've been pretty busy this week, I'll get back to you soon :) I'll double check also alongside the fix you provided in Parse-server |
|
Everything is working in this PR. |
|
I think we also need to improve parse-server's CONTRIBUTING.MD with a handy guide for debugging our own stuff, so that we can work on it and test it iteratively without having to continually rebuild (see Parse-Dashboard example). I've used the following steps to work on Parse-Server. Step 1 — Install Parse Server app example Retrieve the repository with git: Step 2 - Declare your local dependencies in package.json Step 3 - Install and Run Use npm to start the service. In this case, it runs node index.js: Please, let me know if I'm following the right path. Thanks! |
|
You should just have cloned Parse-server and run npm start :) |
|
Hahaha... I think I'm getting older :-/
|
This fixes PR #3717. Sending push with parse-server@2.4.0 returns error
504 GATEWAY_TIMEOUT. This happens when push_time is not set (default).