Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4233 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 116 116
Lines 8111 8111
=======================================
Hits 7480 7480
Misses 631 631Continue to review full report at Codecov.
|
acinader
reviewed
Oct 3, 2017
CHANGELOG.md
Outdated
| * Adds ability to set a maxLimit on server configuration for queries, thanks to [Chris Norris](https://github.com/) | ||
|
|
||
| #### Bug fixes: | ||
| * Fixes issue affecting reporting _PushStatus with misconfigured serverURL, thanks to [Florent Vilmart](https://github.com/flovilmart) |
Contributor
There was a problem hiding this comment.
hm, is the _ in PushSatus making the rest of it itals?? maybe take out that _
Contributor
Author
There was a problem hiding this comment.
yep you're right!
Contributor
There was a problem hiding this comment.
according to the interwens, you can escape with _boo
Contributor
Author
There was a problem hiding this comment.
added backquotes as it looks like code :)
acinader
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.