Adds ability to login with email when specifying it#4276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4276 +/- ##
=========================================
+ Coverage 92.23% 92.43% +0.2%
=========================================
Files 116 118 +2
Lines 8124 8155 +31
=========================================
+ Hits 7493 7538 +45
+ Misses 631 617 -14
Continue to review full report at Codecov.
|
spec/ParseUser.spec.js
Outdated
| }).then(done).catch(done.fail); | ||
| }); | ||
|
|
||
| it('can to login when both email and username are passed', (done) => { |
There was a problem hiding this comment.
can to, probably should just can
spec/ParseUser.spec.js
Outdated
| }).then(done).catch(done.fail); | ||
| }); | ||
|
|
||
| it('fails to login when username dont match email', (done) => { |
There was a problem hiding this comment.
not critical but dont is bugging me
| return rp.get(options); | ||
| }).then(done).catch(done.fail); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Could have an additional test here for trying cannot login with email and bad password, just to cover if a possible bug were introduced regarding password validation with an email at any point.
There was a problem hiding this comment.
Added the test on the next line.
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
This looks pretty good! Just some typos and an additional test and this should be ready to go.
|
Thanks man! |
2 participants
No description provided.