Get ParseConfig parameters with Master Key#5954
Get ParseConfig parameters with Master Key#5954davimacedo merged 4 commits intoparse-community:masterfrom
Conversation
|
This feature requires parse-community/parse-dashboard#1233. |
Codecov Report
@@ Coverage Diff @@
## master #5954 +/- ##
==========================================
- Coverage 93.68% 93.66% -0.03%
==========================================
Files 156 156
Lines 10850 10857 +7
==========================================
+ Hits 10165 10169 +4
- Misses 685 688 +3
Continue to review full report at Codecov.
|
|
This feature already exists or did I miss something? |
|
The feature you are referring to restricts PUTs to the master key. The new feature allows for individual config parameters to be GETtable only with master key. See #5930 for feature description. |
|
@dplewis Any idea why the test is passing for mongodb but fails for postgres? |
|
I have an idea why, let me pull this down and see. |
|
You have to add the masterKeyOnly field to the SchemaController otherwise you get an undefined column error |
|
@dplewis Thanks, what are the implications when I add that field to the schema controller? That field is not always present, for example when upgrading from an existing parse server installation - could that cause any issues? |
|
Its automatically gets updated when the server starts. schemaUpgrade |
dplewis
changed the title
davimacedo
left a comment
davimacedo
left a comment
There was a problem hiding this comment.
It looks good to me. LGTM!
* added saving, retrieving * added tests * fixed typo * added masterKeyOnly to schema controller
3 participants
Adds a property to Parse Config parameter to make it only retrievable with master key.