Pass context in beforeDelete, afterDelete, beforeFind and Parse.Cloud.run.#6666
Pass context in beforeDelete, afterDelete, beforeFind and Parse.Cloud.run.#6666mtrezza merged 16 commits intoparse-community:masterfrom yog27ray:add-context-to-pending-hooks
Conversation
1. beforeDelete 2. afterDelete 3. beforeFind 4. Cloud Function
|
@yog27ray Do you need any help with the failing cases? |
|
@mtrezza these failing test cases depends on parse-community/Parse-SDK-JS#1159 |
|
Got it. Amazing work to see the context now expanded to all these methods! 👍 I should mention some pitfalls I came across with the original PR for |
|
Can you guys tag team this issue here #6736 Sorry I’m kinda out of the loop which is why I didn’t merge the SDK PR |
|
any idea when these context changes may be merged? |
|
@dplewis on travis failing test cases are passing in my local. Can you help me how can I replicate the same. |
Codecov Report
@@ Coverage Diff @@
## master #6666 +/- ##
==========================================
- Coverage 93.90% 93.89% -0.01%
==========================================
Files 169 169
Lines 12048 12047 -1
==========================================
- Hits 11314 11312 -2
- Misses 734 735 +1
Continue to review full report at Codecov.
|
These seem to be randomly failing tests, unrelated to your PR, see #6758. I restarted the build and the tests pass. |
|
@mtrezza can you restart the build. |
|
Done. You can also restart the build by pushing an empty commit |
This extension the of the #6626. To pass context in following calls.
Don't merge until