fix context for cascade-saving and saving existing object#6735
Merged
dplewis merged 8 commits intoparse-community:masterfrom Jul 2, 2020
Merged
fix context for cascade-saving and saving existing object#6735dplewis merged 8 commits intoparse-community:masterfrom
dplewis merged 8 commits intoparse-community:masterfrom
Conversation
3 tasks
Member
|
Thanks for bumping the SDK, I was waiting for the PR from Synx. Can you run npm install to update the package lock? |
Member
Author
|
Yes, it's already running. I gotta head out now, if CI fails I'll take a look at it in a couple of hours. |
Member
|
It looks good to me, can you remove the comments that are self documenting? |
Member
Author
|
You mean these |
Codecov Report
@@ Coverage Diff @@
## master #6735 +/- ##
==========================================
- Coverage 93.89% 93.88% -0.01%
==========================================
Files 169 169
Lines 12047 12048 +1
==========================================
Hits 11311 11311
- Misses 736 737 +1
Continue to review full report at Codecov.
|
Member
Author
|
Looks like a false positive in coverage, ready to merge. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with
contextwhen saving objects:contextis set when saving an existing object:contextis lost when cascade-saving objects so thatcontextis inherited by child objects (obj2in this example):Requires:
closes #6736