refactor: error messages reformatted and moved into own files (#1731)

[fn-faisal]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

Message error for required fields #1731

Related issue: Issue link

Approach

This is a PR regarding the below issue. The formatting has been added to the server. I'll update the existing PR for the dashboard to exclude formatting of response string from dashboard.
parse-community/parse-dashboard#1731 (comment)

[mtrezza]

Not sure about this PR, see parse-community/parse-dashboard#1731 (comment).

[fn-faisal]

I have updated this PR to refactor error messages from server into their own files. This way, the error messages are easier to update. I have also updated the error message for the required fields.

[fn-faisal]

@mtrezza For this one, I refactored the messages in the a separate file and refactored the messages. I wasn't too sure about the changes required for this issue but from what I understood, I refactored the message strings in their own file and referenced them in the error responses.
I didn't see a support for locale strings and wasn't sure if multiple locales were supported so I made a new file for locale string.

[mtrezza]

That's certainly a nice consolidation!

• There are still some error messages that should begin uppercase, I think, for example 'bad or missing username'
• Could you rename the message.js path to be more specific, for example /Errors/messages.js? These should actually go into the Parse JS SDK Parse.Error object, but that is so complicated at the moment that we can leave this here for now. The errors will hopefully go into their own repo in the future, to be able to reference them from all other SDKs as well.
• For the tests to pass, they should also use the error references.

[codecov]

Codecov Report

Merging #7446 (0d6b06a) into alpha (826aa79) will decrease coverage by 0.01%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##            alpha    #7446      +/-   ##
==========================================
- Coverage   93.98%   93.96%   -0.02%     
==========================================
  Files         183      184       +1     
  Lines       13655    13695      +40     
==========================================
+ Hits        12833    12868      +35     
- Misses        822      827       +5     

Impacted Files	Coverage Δ
src/GraphQL/loaders/usersMutations.js	91.39% <25.00%> (+0.09%)	⬆️
src/Adapters/Storage/Mongo/MongoTransform.js	88.12% <62.50%> (+0.01%)	⬆️
src/RestWrite.js	94.20% <71.42%> (ø)
src/Routers/UsersRouter.js	94.41% <82.35%> (+0.03%)	⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	93.37% <83.33%> (+0.01%)	⬆️
src/Errors/message.js	84.84% <84.84%> (ø)
...dapters/Storage/Postgres/PostgresStorageAdapter.js	95.46% <92.85%> (+<0.01%)	⬆️
src/AccountLockout.js	97.61% <100.00%> (+0.05%)	⬆️
src/RestQuery.js	95.71% <100.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826aa79...0d6b06a. Read the comment docs.

[mtrezza]

@fn-faisal Is this ready for review?

[fn-faisal]

@mtrezza Yes, it's ready for review.

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

[mtrezza]

• Could you add a changelog entry?
• I see that some error messages are ending with a period (.), others are not. Should all end with a period or none? I would think that all should end with period, because it makes the end of the message and it allows to concat another message, if that should be necessary in any case. What do you think?

[mtrezza]

Could you take a look at the previous comments, like #7446 (comment). Maybe you did not see some of the comments because they were folded in the thread. These comments mostly require renaming the error keys, to make it easier to understand what they are used for. It would then also be good if you could sort the error messages alphabetically, so we have a list that is easy to read.

Thanks for the effort, this is quite a large change, so it takes some revisions.

[fn-faisal]

Could you take a look at the previous comments, like #7446 (comment). Maybe you did not see some of the comments because they were folded in the thread. These comments mostly require renaming the error keys, to make it easier to understand what they are used for. It would then also be good if you could sort the error messages alphabetically, so we have a list that is easy to read.

Thanks for the effort, this is quite a large change, so it takes some revisions.
@mtrezza
I have gone through the comments and updated the PR.

[mtrezza]

@fn-faisal Apologies for the delay, I should look over this over the next days, it's quite a big (and great ;) PR.

[fn-faisal]

@mtrezza NP 👍 . I've gone through the requested changes have updated the PR as requested. Please let me know if any other updates are required.

[fn-faisal]

@mtrezza I have resolved some of the merge conflicts for the PR. Please let me know of any required updates for the PR once you review it.
Thanks.

[mtrezza]

Thanks @fn-faisal, I'll review in the coming days, apologies for the delay.

[fn-faisal]

@mtrezza ok, sounds good. thanks.

[dblythy]

What is pending here @mtrezza?

[mtrezza]

It needs a rebase and a complete review of the suggested changes.

[fn-faisal]

Hi guys,
I made this PR about a year ago back when I was working at Back4App but as I'm no longer working with them and have moved on to better opportunities, I'm afraid I won't be able to invest time on the open issues anymore.
@mtrezza if you'd like, I'm ok with closing this PR or if someone else would like to pick this one up, that's cool too.

[mtrezza]

Thanks for the heads up, I guess we can keep it open for someone else to continue it.