refactor: minor changes to remove mongo deprecation warnings#7626
refactor: minor changes to remove mongo deprecation warnings#7626mtrezza merged 6 commits intoparse-community:masterfrom
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
+ Coverage 93.97% 94.00% +0.02%
==========================================
Files 181 181
Lines 13354 13354
==========================================
+ Hits 12549 12553 +4
+ Misses 805 801 -4
Continue to review full report at Codecov.
|
|
with this fix no more warnings noticed on test project. this pr is good to go ! |
|
Not a fix, since the issue is not a bug, see contribution guide for how to use commit types. Can you please
|
f3a1f2b to
77a8520
Compare
|
done @mtrezza |
mtrezza
left a comment
There was a problem hiding this comment.
Looks good! Removed unrelated changes.
|
🎉 This change has been released in version 5.0.0-alpha.2 |
|
🎉 This change has been released in version 5.0.0-beta.1 |
|
You said it was a bug here: #7345 (comment) |
|
It's not a bug as it doesn't require a new release. We have no "refactor" label in GitHub issues, so it was classified as trivial bug, but it's not merged a bug but as a refactor, which indeed can cause confusion. Maybe we should add a refactor label for issues. |
|
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Close #7623, #7624
Related issue: #7623, #7624