Skip to content

refactor: minor changes to remove mongo deprecation warnings#7626

Merged
mtrezza merged 6 commits intoparse-community:masterfrom
Moumouls:moumouls/fix-mongodb-warnings
Oct 17, 2021
Merged

refactor: minor changes to remove mongo deprecation warnings#7626
mtrezza merged 6 commits intoparse-community:masterfrom
Moumouls:moumouls/fix-mongodb-warnings

Conversation

@Moumouls
Copy link
Member

@Moumouls Moumouls commented Oct 14, 2021

New Pull Request Checklist

Issue Description

Close #7623, #7624

Related issue: #7623, #7624

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 14, 2021

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@Moumouls Moumouls requested a review from mtrezza October 14, 2021 09:31
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #7626 (8770cb4) into master (936b5ec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
+ Coverage   93.97%   94.00%   +0.02%     
==========================================
  Files         181      181              
  Lines       13354    13354              
==========================================
+ Hits        12549    12553       +4     
+ Misses        805      801       -4     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.33% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936b5ec...8770cb4. Read the comment docs.

@Moumouls
Copy link
Member Author

Moumouls commented Oct 14, 2021

with this fix no more warnings noticed on test project. this pr is good to go !

@mtrezza
Copy link
Member

mtrezza commented Oct 14, 2021

Not a fix, since the issue is not a bug, see contribution guide for how to use commit types.

Can you please

  • adapt the change log entry
  • delete the todos that don't apply to this PR

@mtrezza mtrezza changed the title fix: remove mongo warnings refactor: remove mongo warnings Oct 14, 2021
@mtrezza mtrezza changed the title refactor: remove mongo warnings refactor: minor changes to remove mongo deprecation warnings Oct 14, 2021
@Moumouls Moumouls force-pushed the moumouls/fix-mongodb-warnings branch from f3a1f2b to 77a8520 Compare October 14, 2021 12:43
@Moumouls
Copy link
Member Author

done @mtrezza

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Removed unrelated changes.

@mtrezza mtrezza merged commit 68057c4 into parse-community:master Oct 17, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 27, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@Moumouls Moumouls mentioned this pull request Nov 4, 2021
3 tasks
@rocxteady
Copy link

You said it was a bug here: #7345 (comment)
But you said it is not a bug here in this pull request.

@mtrezza
Copy link
Member

mtrezza commented Dec 18, 2021

It's not a bug as it doesn't require a new release. We have no "refactor" label in GitHub issues, so it was classified as trivial bug, but it's not merged a bug but as a refactor, which indeed can cause confusion. Maybe we should add a refactor label for issues.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprectation warning returnOriginal mongo

4 participants