fix: postgresql protocol in database connection string assumes MongoDB database#7688
Closed
pmmlo wants to merge 7 commits intoparse-community:alphafrom
Closed
fix: postgresql protocol in database connection string assumes MongoDB database#7688pmmlo wants to merge 7 commits intoparse-community:alphafrom
postgresql protocol in database connection string assumes MongoDB database#7688pmmlo wants to merge 7 commits intoparse-community:alphafrom
Conversation
- This should allow developers to designate either postgres:// or postgresql:// prefixed URIs for PostgreSQL.
Thanks for opening this pull request!
|
pmmlo
changed the title
pmmlo
changed the title
mtrezza
requested changes
Nov 10, 2021
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
Can you please add a test for that protocol?
| collectionPrefix, | ||
| databaseOptions, | ||
| }); | ||
| case 'postgresql:': |
Member
There was a problem hiding this comment.
Please use fall-through behavior instead of duplicating code
mtrezza
changed the title
postgresql protocol in database connection string assumes MongoDB database
Codecov Report
@@ Coverage Diff @@
## alpha #7688 +/- ##
==========================================
- Coverage 93.98% 93.87% -0.11%
==========================================
Files 183 183
Lines 13655 13625 -30
==========================================
- Hits 12833 12791 -42
- Misses 822 834 +12
Continue to review full report at Codecov.
|
Member
|
Closed because already fixed as #7757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
This allows developers to use both valid PostgreSQL URI prefixes: "postgresql://" or "postgres://".
Reference: PostgreSQL Connection String Documentation
Related issue: #7687
Approach
I added a switch case for postgresql protocol to get the PostgresStorageAdapter.
TODOs before merging