refactor: remove unnecessary error checking in PostgresAdapter#7761
Merged
mtrezza merged 3 commits intoparse-community:alphafrom Jan 2, 2022
cbaker6:cleanPostgres
Merged
refactor: remove unnecessary error checking in PostgresAdapter#7761mtrezza merged 3 commits intoparse-community:alphafrom cbaker6:cleanPostgres
mtrezza merged 3 commits intoparse-community:alphafrom
cbaker6:cleanPostgres
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## alpha #7761 +/- ##
==========================================
+ Coverage 93.96% 93.99% +0.02%
==========================================
Files 183 183
Lines 13640 13635 -5
==========================================
- Hits 12817 12816 -1
+ Misses 823 819 -4
Continue to review full report at Codecov.
|
Contributor
Author
|
@mtrezza this is ready for review. |
mtrezza
approved these changes
Jan 2, 2022
Contributor
|
🎉 This change has been released in version 5.0.0-alpha.16 |
Contributor
|
🎉 This change has been released in version 5.0.0-beta.10 |
Contributor
|
🎉 This change has been released in version 5.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
There are unnecessary error checks in
PostgresStorageAdapter.jsthat were left over from addingIF NOT EXISTSin #6741 and #6506Related issue: #6741 and #6506
Approach
Remove error checks and code that isn't used anymore.
TODOs before merging