docs: Change API docs template to jsdoc-clean-theme#8519
docs: Change API docs template to jsdoc-clean-theme#8519mtrezza merged 5 commits intoparse-community:alphafrom coratgerl:alpha
Conversation
|
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8519 +/- ##
==========================================
- Coverage 94.33% 94.33% -0.01%
==========================================
Files 183 183
Lines 14515 14515
==========================================
- Hits 13693 13692 -1
- Misses 822 823 +1
☔ View full report in Codecov by Sentry. |
|
There are a lot of configurable options for jsdoc-clean-theme. We can customize it as you like :) https://github.com/ankitskvmdam/clean-jsdoc-theme#options |
|
Well, just the color scheme seems to be a bit off. The "Parse Blue" seems somewhat missing. Is there a way to configure colors? |
There was a problem hiding this comment.
Could you take a look at why the definitions check fails? You could run npm run definitions and see what files change.
I run : |
|
The color changes in the screenshot above look good! Could you post here what these changes are in the definition files? This PR shouldn't cause any changes there actually. |
|
It's weird in local the npm run ci:definitionsCheck not fail. I don't see any change after the run definitions, just the files write by the prettier 🤔 |
mtrezza
left a comment
There was a problem hiding this comment.
Looks good! Definitions check passed this time, not sure why it failed previously.
Is this ready for merge?
|
It's ready for me :). Thanks for the feedbacks ;). You can also close this PR as long as you are the (same subject) #8021 |
|
🎉 This change has been released in version 6.1.0-alpha.8 |
|
🎉 This change has been released in version 6.1.0-beta.2 |
|
🎉 This change has been released in version 6.1.0 |

Pull Request
Issue
Closes: #8017
Approach
Modernize the API doc template with jdoc-clean-theme.
Tasks
Changes
I had to fix some documentation to avoid duplicate Modules or duplicate class 🙂
Before :

After: