Skip to content

refactor: Upgrade lru-cache from 7.12.0 to 9.1.1 #8559

Merged
mtrezza merged 9 commits intoparse-community:alphafrom
dblythy:upgrade-lru
May 25, 2023
Merged

refactor: Upgrade lru-cache from 7.12.0 to 9.1.1 #8559
mtrezza merged 9 commits intoparse-community:alphafrom
dblythy:upgrade-lru

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented May 22, 2023

Pull Request

Issue

Closes: #8548

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 22, 2023

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (28aeda3) 94.32% compared to head (0e88ee0) 94.33%.

❗ Current head 0e88ee0 differs from pull request most recent head d2ae964. Consider uploading reports for the commit d2ae964 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #8559   +/-   ##
=======================================
  Coverage   94.32%   94.33%           
=======================================
  Files         183      183           
  Lines       14576    14576           
=======================================
+ Hits        13749    13750    +1     
+ Misses        827      826    -1
Impacted Files Coverage Δ
src/Adapters/Cache/LRUCache.js 100.00% <100.00%> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.99% <100.00%> (ø)
src/LiveQuery/SessionTokenCache.js 87.50% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy requested a review from a team May 22, 2023 06:55
mtrezza
mtrezza reviewed May 22, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only an internal change, or is this a breaking change because we allow developers to interact with the cache directly and customize it?

@dblythy
Copy link
Member Author

dblythy commented May 23, 2023

I believe this is only an internal change

mtrezza
mtrezza reviewed May 24, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an issue here; the CI ran 3 times already and Node 14 always fails with the same 17 errors.

@dblythy
Copy link
Member Author

dblythy commented May 25, 2023

I think it's #8577

@mtrezza mtrezza merged commit c2e4f83 into parse-community:alpha May 25, 2023
@parseplatformorg
Copy link
Contributor

parseplatformorg commented May 27, 2023

🎉 This change has been released in version 6.1.0-alpha.14

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2023
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jun 10, 2023

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jun 18, 2023

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Sep 16, 2023

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dblythy @parseplatformorg @mtrezza @snyk-bot