Update Auth.js and solved some potential bugs.#9605
Open
Ujjawal-Kantt wants to merge 1 commit intoparse-community:alphafrom
Open
Update Auth.js and solved some potential bugs.#9605Ujjawal-Kantt wants to merge 1 commit intoparse-community:alphafrom
Ujjawal-Kantt wants to merge 1 commit intoparse-community:alphafrom
Conversation
Signed-off-by: Ujjawal Kantt <124806392+Ujjawal-Kantt@users.noreply.github.com>
Thanks for opening this pull request!
|
Member
|
@Ujjawal-Kantt in light of recent fixes in auth adapters, and changes in throttle, is this PR still relevant? If so, you may want to break it down into individual PRs, each one addressing a specific issue, unless where it makes to combine into a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: Issue #XXXX
Approach
This PR fixes memory leaks, improves session management, enhances security, and optimizes authentication logic in the
Auth.jsfile.Key Changes:
Fixed Memory Leak in
throttleMap()to track session timeouts.Improved Role Fetching Mechanism
this.userRolesupdates correctly.Enhanced Session Token Management
sessionTokenvalues are handled properly.Optimized Security Checks & Error Handling
Updated
renewSessionIfNeededLogicTasks