PARSEC-5223 - Add various fixes for WASM app#175
Open
mtrang1263 wants to merge 10 commits intostablefrom
Open
Conversation
mtrang1263
commented
Mar 5, 2026
mtrang1263
commented
Mar 5, 2026
mtrang1263
commented
Mar 5, 2026
mtrang1263
commented
Mar 5, 2026
mtrang1263
added
the
2. Review requested
Namaneo
requested changes
Mar 6, 2026
Namaneo
added
1. Coding
Namaneo
approved these changes
Mar 6, 2026
Namaneo
added
2. Review requested
mtrang1263
force-pushed
the
mt-fix-webapp
branch
from
07330a7 to
d6f9430
Compare
mtrang1263
commented
Mar 12, 2026
| if (!MTY.ccanvas) { | ||
| MTY.ccanvas = document.createElement('canvas'); | ||
| MTY.cctx = MTY.ccanvas.getContext('2d'); | ||
| MTY.cctx = MTY.ccanvas.getContext('2d', {"willReadFrequently": true}); |
Author
There was a problem hiding this comment.
Resolve warning we were receiving with the cursor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This PR relies on: https://github.com/WebAssembly/js-promise-integration/blob/main/proposals/js-promise-integration/ImplementationGuide.md#jspi-implementation-notes to correctly implement MTY_RunAndYield. This is available on chrome browsers since 137 which was released in May 2025.
We do have fallbacks to the old behavior that does not consume excessive memory but also does not support the cleanup of streams.
Blocks: https://github.com/parsec-cloud/parsec/pull/2063