Please review#59
Merged
abergs merged 12 commits intopasswordless-lib:masterfrom Oct 28, 2018
aseigler:master
Merged
Conversation
Collaborator
aseigler
commented
Oct 19, 2018
aseigler
commented
- Added PeterO.Cbor as local project to close [Security] Remove dependency on PeterO.Cbor package #7
- Added Chaos.NaCl as local project for EdDSA support
- Added Yubico root and known aaguid to custom metadata to support trust path verification for at least some Yubico devices
If unconfigured, continue silently.
Collaborator
|
Will hopefully be able to review tomorrow. Github says it has conflicts but not sure if that's a false alarm? |
…y and improve readability
Adding a failing test captured from conformance tool ALG_SIGN_SECP521R1_ECDSA_SHA512_RAW.
Collaborator
Author
|
I haven't seen any conflicts? |
Collaborator
|
This is the Github UI, but I can try to do it manually. Do have any more commits or are you good to go?
|
Collaborator
Author
|
That's bizarre...this is what I see. I don't have anything else right at the moment, I was mainly concerned about adding the CBOR and Chaos.NaCl projects. It works fine for me, just wanted to make sure it works for you and that it was done properly. |
Collaborator
|
I think that is because I run the rebase and merge mode. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.