Properties of PublicKeyCredentialType enum are nullable#73
Merged
aseigler merged 1 commit intopasswordless-lib:masterfrom Jan 14, 2019
Merged
Properties of PublicKeyCredentialType enum are nullable#73aseigler merged 1 commit intopasswordless-lib:masterfrom
aseigler merged 1 commit intopasswordless-lib:masterfrom
Conversation
Merged
Collaborator
|
@aseigler can you run tests on this branch and see if this fixes the issue? (I'm unable at the moment) |
Collaborator
|
I will try to get it tested tonight. |
Collaborator
|
The two conformance tests related to this issue both pass acceptably with this fix applied. The third one is actually not related to this update but a new requirement in the conformance test tool. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow nulls in properties of PublicKeyCredentialType enum as mentioned here.