Allow time format in translogger to be configured by kwarg #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no arg is provided, a default_time_format is used. Fixes #73
FND
reviewed
Aug 27, 2023
| setup_console_handler=True, | ||
| set_logger_level=logging.DEBUG): | ||
| set_logger_level=logging.DEBUG, | ||
| time_format=None): |
There was a problem hiding this comment.
why not assign the default right here?
Suggested change
| time_format=None): | |
| time_format=default_time_format): |
Collaborator
Author
There was a problem hiding this comment.
Basically just to keep the same pattern used for format in line 28/34.
Which is perhaps not sufficient reason technically, but I tend to want to stick with existing patterns, especially in paste where everything is so weird and old and sometimes confusing.
Thus minimal changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no arg is provided, a default_time_format is used.
Fixes #73