Import songs reflects the last patacrep changes#142
Merged
Conversation
added 2 commits
October 27, 2015 21:30
Author
|
Au passage cela résout #98 |
Contributor
|
Le code me semble bon. Laisse moi juste tester le tout en local ! |
Contributor
|
C'est tout bon pour moi ! |
oliverpool
pushed a commit
that referenced
this pull request
Oct 27, 2015
Import songs reflects the last patacrep changes
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J'ai fait une grosse mise à jour de la commande
importsongspour notamment refléter les derniers changements de patacrep.J'en ai profité pour diminuer les accès à la base de donnée (pour 900 chants, cela prend quelques secondes).
En revanche le premier parsage des chants par patacrep peut prendre un peu de temps (heureusement une mise en cache est effectuée pour les accès ultérieurs).
J'apprécierai que quelqu'un y jette un oeil avant de merger (ping @Luthaf)