API version 2.1.0 See https://docs.patch.io/#/changelog for changes #72
Conversation
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
from
f7cbdf2 to
7384e35
Compare
.github/workflows/test.yml
Outdated
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '3.6' | ||
| python-version: '3.10' |
There was a problem hiding this comment.
There appears to be a long-running problem with versions 3.6 and 3.9 as seen in this thread. In our case I don't believe it hurts to bump to 3.10
There was a problem hiding this comment.
Agree. But I'm not sure we should change the required version for the package: https://github.com/patch-technology/client-code-generation/pull/70#pullrequestreview-1359412217
There was a problem hiding this comment.
Oh yeah, that makes sense. I'll also poke around to make sure that we need this at all; the publish.yml file still has a version of 3.6, so I'm wondering if this needs any change at all
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
5 times, most recently
from
e9f0839 to
91cc346
Compare
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
from
91cc346 to
f874f16
Compare
pcothenet
left a comment
pcothenet
left a comment
There was a problem hiding this comment.
Discussion on python version before merging.
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
5 times, most recently
from
7e12496 to
56a943e
Compare
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
from
56a943e to
c3a9801
Compare
|
@pcothenet thanks for the nudge to look into the python issues more deeply! It looks like pinning the ubuntu version remedies the situation and avoids an unnecessary python upgrade. It seems like there's an underlying issue with the python tarballs for |
Sounds good to me. I think you could also keep the test running on 3.10, but not force that as a min version for the SDK (ultimately, we should have a test matrix of multiple Python versions for this SDK) |
|
Ah yeah a test matrix would be ideal and hopefully is in our near future. For now I was thinking that it would be best to have the tests run on the same version that the package is published to maintain consistency! |
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
from
e4de7fe to
5d4f6c9
Compare
| ) | ||
| self.assertEqual(estimate.data.order, None) | ||
| self.assertEqual(estimate.data.type, "shipping") | ||
| self.assertEqual(estimate.data.type, "ecommerce") |
There was a problem hiding this comment.
We're now re-routing to the ecommerce endpoint: https://github.com/patch-technology/patch/pull/5588
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
from
5d4f6c9 to
8b84a2a
Compare
venalen
force-pushed
the
venalen/python-sdk-2.1.0
branch
from
8b84a2a to
a9ebe61
Compare
What
API version 2.1.0. See https://docs.patch.io/#/changelog for changes
Why
Version 2.1.0 adds support for
vintage_start_yearandvintage_end_yearfor ordersvintage_start_yearandvintage_end_yearfor order line itemsvintage_start_yearandvintage_end_yearfor inventorycarrier_scacfield topatch.estimates.create_road_shipping_estimateSDK Release Checklist
If endpoints were removed, did you manually remove the corresponding files? (this should be rare)For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?