Fix the generator for optional body parameters #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcothenet
commented
Jul 29, 2022
lib/patch_ruby/api/orders_api.rb
Outdated
Comment on lines
168
to
171
| def place_order(order_id, opts = {}) | ||
| place_order_request = Patch::PlaceOrderRequest.new(opts) | ||
| opts[:place_order_request] = place_order_request | ||
| data, _status_code, _headers = place_order_with_http_info(order_id, opts) | ||
| def place_order(place_order_request = {}, opts = {}) | ||
| _place_order_request = Patch::PlaceOrderRequest.new(place_order_request) | ||
| data, _status_code, _headers = place_order_with_http_info(_place_order_request, opts) |
Contributor
Author
There was a problem hiding this comment.
This change should not be happening 😢
pcothenet
changed the title
pcothenet
commented
Jul 29, 2022
|
|
||
| # Creates a GLEC air shipping estimate given freight mass and logistics | ||
| # Creates a GLEC air shipping estimate for the amount of CO2 to be compensated. An order in the `draft` state may be created based on the parameters, linked to the estimate. | ||
| # Creates a GLEC air shipping estimate for the amount of CO2 to be compensated. An order in the `draft` state may be created based on the parameters, linked to the estimate. |
Contributor
Author
There was a problem hiding this comment.
I fixed the bug in the template that was escaping those values.
pcothenet
commented
Jul 29, 2022
Comment on lines
-168
to
173
| # @return [OrderResponse] | ||
| def place_order(order_id, opts = {}) | ||
| place_order_request = Patch::PlaceOrderRequest.new(opts) | ||
| opts[:place_order_request] = place_order_request | ||
| data, _status_code, _headers = place_order_with_http_info(order_id, opts) | ||
| def place_order(id, opts = {}) | ||
|
|
||
| data, _status_code, _headers = place_order_with_http_info(id, opts) | ||
| data | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This version had (most likely) be written manually. The new one is entirely generated by the templates.
pcothenet
commented
Jul 29, 2022
| let(:instance_hash) { { project_id: @instance.project_id, mass_g: @instance.mass_g, total_price_cents_usd: @instance.total_price_cents_usd, metadata: @instance.metadata } } | ||
| let(:nullable_properties) do | ||
| Set.new(%i[mass_g total_price_cents_usd project_id metadata state vintage_year total_price currency amount unit issued_to]) | ||
| Set.new(%i[mass_g total_price_cents_usd project_id metadata state vintage_year total_price currency amount unit]) |
Contributor
Author
There was a problem hiding this comment.
I had to change this line because of the new swagger file, but don't think this matters.
pcothenet
commented
Jul 29, 2022
|
|
||
| # Creates a GLEC air shipping estimate given freight mass and logistics | ||
| # Creates a GLEC air shipping estimate for the amount of CO2 to be compensated. An order in the `draft` state may be created based on the parameters, linked to the estimate. | ||
| # Creates a GLEC air shipping estimate for the amount of CO2 to be compensated. An order in the `draft` state may be created based on the parameters, linked to the estimate. |
Contributor
Author
There was a problem hiding this comment.
Also fixed this escaping in the generator.
kleinjm
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
swagger.jsonfile to define theissued_toparameter (leading to better file name)Why
Notes
SDK Release Checklist