Skip to content

Expect > 0 for shipping estimates since mass is randomized in tests #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holtbp merged 1 commit into from
Aug 3, 2022
Merged

Expect > 0 for shipping estimates since mass is randomized in tests #70

holtbp merged 1 commit into from
Aug 3, 2022

Conversation

@holtbp
Copy link
Contributor

@holtbp holtbp commented Aug 3, 2022

What

Updating test expectations.

Why

To ensure no flakiness.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version in the code generator?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@holtbp holtbp requested review from a team and pcothenet August 3, 2022 17:52
@holtbp holtbp merged commit c6cfff8 into main Aug 3, 2022
@holtbp holtbp deleted the bh-fix-tests branch August 3, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcothenet pcothenet pcothenet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holtbp @pcothenet