Skip to content

Expect 'ecommerce' estimate type returned instead of deprecated 'ship… #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holtbp merged 2 commits into from
Apr 4, 2023
Merged

Expect 'ecommerce' estimate type returned instead of deprecated 'ship… #75

holtbp merged 2 commits into from
Apr 4, 2023

Conversation

@holtbp
Copy link
Contributor

@holtbp holtbp commented Apr 1, 2023 •
edited
Loading

…ping' type

What

Expect ecommerce type in estimate response instead of shipping

Why

Update test expectation to match deprecated type change in response.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version in the code generator?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@holtbp holtbp requested a review from a team April 4, 2023 21:33
@holtbp holtbp merged commit ed569b9 into main Apr 4, 2023
@holtbp holtbp deleted the bh/update-shipping-estimate-spec branch April 4, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@venalen venalen venalen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holtbp @venalen