Open
Conversation
a066e19 to
bc6d507
Compare
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
bc6d507 to
b5e9685
Compare
Member
|
That's roughly 5-6x times faster (without lazy hydration), thats neat! Should we keep this as is, or should we bench it once locally and have it in the readme or blog? As it seems that dragging this along with us does not make much sense, does it? I mean, benching symfony serializer for every PR here is not really useful. Wdyt? |
DanielBadura
reviewed
Sep 6, 2025
| public function __construct() | ||
| { | ||
| $this->serializer = new Serializer([ | ||
| new ObjectNormalizer(), |
Member
There was a problem hiding this comment.
Hm, don't we need also a dedicated ProfileIdNormalizer for an exact comparison?
Member
b5e9685 to
7387d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.