Open
Conversation
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DanielBadura
approved these changes
Apr 9, 2024
Member
DanielBadura
left a comment
There was a problem hiding this comment.
Feature itself LGTM.
Just thinking about instead of passing an array to the UnionObjectNormalizer leveraging the #[NormalizedName] Attribute or something like that. But also that is kina weird, since it does not really bring any value itself.
| /** @param array<class-string, string> $classToTypeMap */ | ||
| public function __construct( | ||
| private readonly array|null $classToTypeMap = null, | ||
| private readonly string $typeFieldName = '_type', |
Member
There was a problem hiding this comment.
it's not the type but instead the type key right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.