Skip to content

[DPL-2013] Logging improvements#4

Merged
alyssaruth merged 2 commits into
mainfrom
dpl-2013-logging-tweaks
Aug 21, 2025
Merged

[DPL-2013] Logging improvements#4
alyssaruth merged 2 commits into
mainfrom
dpl-2013-logging-tweaks

Conversation

@alyssaruth
Copy link
Copy Markdown
Contributor

I've been looking at a flavour of flakiness that involves some kind of slow call to test control, this PR is making various logging improvements that would've made this easier:

  • Add a UUID to request/response logs so they can be correlated
  • Add request duration for successful calls
  • Tweak the logic so 4xx / 5xx responses are logged as errors, instead of lines like this which are annoying to try and hunt for:
{"message":"2025-08-04T21:08:39.350414645Z stderr F 2025/08/04 21:08:39 Success forwarding request /io-pkb-testcontrol-clearInternalState to upstream phr-webapp at http://phr-webapp-k8s113-ms1.pkb.svc.cluster.local/.:9876: 500"}

@alyssaruth alyssaruth requested review from a team and MFAshby August 20, 2025 15:17
MFAshby
MFAshby previously approved these changes Aug 20, 2025
@alyssaruth alyssaruth merged commit 6b72dbb into main Aug 21, 2025
1 check passed
@alyssaruth alyssaruth deleted the dpl-2013-logging-tweaks branch August 21, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants