Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an integration test to verify that the CLI correctly generates a Dockerfile.dot file, comparing the output against a golden file.
- Adds a new golden file (Dockerfile.golden.dot) containing the expected Graphviz DOT content.
- Implements integration tests in integration_test.go that copy an example Dockerfile, run the CLI, and validate the generated DOT file against the golden file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/cmd/testdata/Dockerfile.golden.dot | Adds a new golden file with pre-defined DOT content for CLI verification. |
| internal/cmd/integration_test.go | Introduces integration tests for the CLI that generates the DOT file. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an integration test to verify that the CLI correctly generates a Dockerfile.dot output by building the project, running a Docker container, and comparing the generated file against a golden file.
- Adds a new golden DOT file in internal/cmd/testdata/Dockerfile.golden.dot.
- Implements an integration test in internal/cmd/integration_test.go to build and execute the CLI, then verify its output.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/cmd/testdata/Dockerfile.golden.dot | Provides the expected DOT graph output for comparison in tests. |
| internal/cmd/integration_test.go | Contains an integration test that builds the project and verifies CLI output against the golden file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.