feat: switch default container image from Ubuntu to Alpine#668
Merged
patrickhoefler merged 5 commits intomainfrom May 23, 2025
Merged
feat: switch default container image from Ubuntu to Alpine#668patrickhoefler merged 5 commits intomainfrom
patrickhoefler merged 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches the default container image from Ubuntu to Alpine while still providing support for an Ubuntu-based image.
- Dockerfile now builds an Alpine-based release image
- A dedicated Dockerfile.ubuntu is created while Dockerfile.alpine is removed
- README.md, Makefile, .goreleaser.yaml, and workflow files are updated to reflect these changes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/testdata/Dockerfile.golden.dot | Adjusted coordinate values in the graph to match new expectations |
| README.md | Updated image tags and commands to clarify which image is default and which is Ubuntu-based |
| Makefile | Revised build targets to reference the updated Dockerfiles for Alpine and Ubuntu |
| Dockerfile.ubuntu | New file for building the Ubuntu-based image |
| Dockerfile.alpine | Removed in favor of the unified Dockerfile for Alpine |
| Dockerfile | Modified to use Alpine as the base image instead of Ubuntu |
| .goreleaser.yaml | Updated image templates to include both Alpine (default) and Ubuntu tags |
| .github/workflows/lint_and_test.yml | Updated workflow commands to test the Ubuntu-based image in particular scenarios |
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default container image from Ubuntu to Alpine, introduces a dedicated Ubuntu variant, and updates associated build/test tooling.
- Default Dockerfile is now Alpine-based and a new
Dockerfile.ubuntuprovides an Ubuntu-based image. - Build scripts and CI workflows are updated to reflect the new default and to explicitly build/test the Ubuntu variant.
- Documentation and release configuration (
README.md,.goreleaser.yaml) are adjusted to mark Alpine as default and add Ubuntu tags.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/testdata/Dockerfile.golden.dot | Tweaked graph coordinates to match the new default (Alpine) image |
| README.md | Marked Alpine image as default and updated Docker run tags for both Alpine and Ubuntu |
| Makefile | Swapped Dockerfile references for Alpine/Ubuntu targets and enabled CGO_ENABLED=0 for Linux |
| Dockerfile | Switched base to Alpine, updated package manager commands |
| Dockerfile.ubuntu | Added Ubuntu-based release image with APT setup |
| Dockerfile.alpine | Removed old Alpine-specific file now covered by default Dockerfile |
| .goreleaser.yaml | Added Ubuntu Dockerfile section, updated image templates |
| .github/workflows/lint_and_test.yml | Updated CI steps to test the Ubuntu image variant |
Comments suppressed due to low confidence (2)
Dockerfile:20
- The default Alpine Dockerfile no longer includes the
COPY dockerfilegraph /andENTRYPOINT ["/dockerfilegraph"]steps, so containers won’t have the binary or entrypoint defined. Re-add those instructions afterUSER app.
USER app
.goreleaser.yaml:25
- The Alpine
image_templatesentries have lost theirdockerfile: Dockerfile.alpineparent mapping, breaking the YAML structure. Reintroduce the- dockerfile: Dockerfile.alpineblock (properly indented) to associate those templates with the Alpine Dockerfile.
- - dockerfile: Dockerfile.alpine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.