Skip to content

fix: replace panics with proper error returns in dockerfile2dot #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickhoefler merged 6 commits into from
Mar 12, 2026
Merged

fix: replace panics with proper error returns in dockerfile2dot #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82dd428
fix: replace panics with proper error returns in dockerfile2dot
patrickhoefler Mar 12, 2026
e598cb9
fix: add bounds checks in getWaitForNodeID and error-path tests
patrickhoefler Mar 12, 2026
438110d
fix: quote DOT labels for before-first-stage nodes consistently
patrickhoefler Mar 12, 2026
138ae35
fix: make addStageWithLayers own its error collection and improve err…
patrickhoefler Mar 12, 2026
31049ed
fix: surface earliest error consistently across BuildDotFile helpers
patrickhoefler Mar 12, 2026
df2b1a7
fix: quote cluster stage labels explicitly in addStageWithLayers
patrickhoefler Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ It creates a visual graph representation of the build process.`,
}
defer os.Remove(dotFile.Name())

dotFileContent := dockerfile2dot.BuildDotFile(
dotFileContent, err := dockerfile2dot.BuildDotFile(
dockerfile,
f.concentrate,
f.edgestyle.String(),
Expand All @@ -96,6 +96,9 @@ It creates a visual graph representation of the build process.`,
fmt.Sprintf("%.2f", f.nodesep),
fmt.Sprintf("%.2f", f.ranksep),
)
if err != nil {
return
}

_, err = dotFile.Write([]byte(dotFileContent))
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions internal/cmd/root_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ It creates a visual graph representation of the build process.
stage_0_layer_1->stage_2_layer_1[ arrowhead=empty, ltail=cluster_stage_0, style=dashed ];
stage_1_layer_1->stage_2_layer_2[ arrowhead=empty, ltail=cluster_stage_1, style=dashed ];
subgraph cluster_stage_0 {
label=ubuntu;
label="ubuntu";
margin=16;
stage_0_layer_0 [ fillcolor=white, label="FROM ubuntu:lates...", penwidth=0.5, shape=box, style="filled,rounded", width=2 ];
stage_0_layer_1 [ fillcolor=white, label="RUN apt-get updat...", penwidth=0.5, shape=box, style="filled,rounded", width=2 ];
Expand All @@ -191,7 +191,7 @@ It creates a visual graph representation of the build process.
;
subgraph cluster_stage_2 {
fillcolor=grey90;
label=release;
label="release";
margin=16;
style=filled;
stage_2_layer_0 [ fillcolor=white, label="FROM scratch AS r...", penwidth=0.5, shape=box, style="filled,rounded", width=2 ];
Expand Down
Loading
Loading