fix matching asset filenames containing querystring#59
Merged
Conversation
patrickhulce
approved these changes
Mar 18, 2022
Owner
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks very much @ArTiSTiX !
ArTiSTiX
force-pushed
the
fix-regex-filename
branch
from
0243790 to
a9334f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57
Assets can potentially have querystrings, messing up with the FONT_REGEX not detecting fonts.
We allow querystrings in filename, and strip the querystring part anywhere we need to check extension (path package does not handle querystrings).
NOTE: If you have suggestions to improve this, let me know, i did not want to change too much the existing logic, but it's a blocker on my project.