don't crawl files that haven't been modified since the last crawl #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 7232 §4.1, when a page is returned with a 304 Not Modified header, it is recommended that headers such as Content-Type should not be sent the the client again. When verbose logging in osg is enabled, this would manifest as not crawling a page because its content type was an empty string. Instead of doing that, we should just log that the page hasn't been modified and avoid crawling it completely. This is okay since a 304 response isn't permitted to have a response body anyway, so there's no need to crawl it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 7232 §4.1, when a page is returned with a 304 Not Modified header, it is recommended that headers such as Content-Type should not be sent the the client again. When verbose logging in osg is enabled, this would manifest as not crawling a page because its content type was an empty string.
Instead of doing that, we should just log that the page hasn't been modified and avoid crawling it completely. This is okay since a 304 response isn't permitted to have a response body anyway, so there's no need to crawl it.