cli package cleanPublic option broken

[kryp71c]

I am using Pattern Lab Node v3.0.0-beta.3 on Mac, with Node v10.15.0, using a Vanilla Edition.

Expected Behavior

Setting "cleanPublic": true in patternlab-config.json should remove the destination directory before compiling.

Actual Behavior

The cleanPublic setting has no effect.

The build.js file in the cli package currently passes a boolean literal to the patternlab build and patternsonly methods. However these methods expect an object with a key of "cleanPublic". Consequentially a check in buildPatterns.js (of core) then evaluates incrementalBuildsEnabled as true. This in turn prevents the destination directory from being "cleaned".

Instead of the boolean literal the whole config object should be passed as an argument, which fixes the issue.

[kryp71c]

something similar is happening with cli serve. The options meant for the server seem to be passed along to patternlab.build which breaks the option.

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

[zhawkins]

If this worked correctly it could be used to bypass the issue presented in #1015. This also looks related to #988.

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

[stale]

Issue closed after going stale. It can be re-opened if still relevant.