Nested subtypes do not render without root pattern

[illepic]

I am using Pattern Lab Node (see screenshot) on Mac, with Node v10.16.3, using the twig php renderer.

Expected Behavior

We nest our non-underscore template files in a demo/ folder, a la:

Up until the recent uikit update, the demo/buttons.twig pattern would render just fine in the UI at atoms -> button -> buttons.

Actual Behavior

No navigation entries are created for button:

This "Button" nav item links to non-existent rendered html file.

Steps to Reproduce

Create a pattern such that the renderable template file is in a nested folder only, ie:

atoms
  button
    _button.twig
    demo
      buttons.twig

"Buttons" will not be available in the navigation UI.

Note: adding a dummy twig file a the root of the pattern results in proper rendering of the navigation. This is how we're circumventing this for now.

[sghoweri]

HMMM I might need to pop open the Nav component’s JSX to see what the data looks like when this is busted vs working as expected.

Assuming the Nav data itself is all there, my best guess would be that the nested nav logic doesn’t see any immediate children so it skips rendering the rest of the Nav section (even though grandchildren exist) — or something to that effect.

Thanks for the ticket @illepic!

[sghoweri]

@illepic do you know if this issue was also happening in v1.0.3 of UIKit or if it just started happening with 1.0.4?

[illepic]

@sghoweri, the most recent version we were using was 1.0.1, and all of our "plural" patterns within demo/ rendered great in the nav. I bumped to 1.0.4 last night and noticed this.

[illepic]

Noting here that the issue may manifest in this way as well:

TLDR: hidden (underscore) patterns appear to show in the nav when attempting to circumvent the original issue by adding a dummy visible (non-underscore) pattern to the root of the pattern. But, this link does, in fact, link to demos/derps.twig! So we're getting a link named like a hidden pattern that links to a non-hidden pattern.

Fun fact, if I rename demo/derps.twig to something else, say, demo/derps-herps.twig, then the UI renders fine:

Is there a regex at play that may conflate singular vs plural names of patterns?

[sghoweri]

@illepic not sure... I'm trying to reproduce your folder structure in PL PHP using the exact same UIKit code to narrow down where to look.

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

[stale]

Issue closed after going stale. It can be re-opened if still relevant.