-
Notifications
You must be signed in to change notification settings - Fork 402
Description
I am using Pattern Lab Node v5.15.7 on Mac, with Node v12.13.1, using a Vanilla Edition and Handlebars Engine.
Expected Behavior
The plugins API should get used correctly according to its documentation.
Actual Behavior
It seems like that the implementation within the lines https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/scripts/components/modal-viewer.js#L233 don't follow the API provided by the plugin, and would need get further analyzed.
Steps to Reproduce
Analyzing this is currently blocked (or necessary to use the current work out of #1402), as the annotations aren't being both correctly displayed and we don't include any sample content at the moment in our handlebars engines demo content.
Things to keep in mind
The final result doesn't necessarily have to be to correctly use the plugin, but to first understand the reason for the code within https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/scripts/components/modal-viewer.js#L233; as the package scroll-js has made a huge node.js compatibility jump within its latest minor version (from 12 to 16), we need a replacement anyhow (maybe evaluate to go pure native, as the smooth scrolling behaviour is supported right now, compare to MDN and another article).