Skip to content

feat(config): add new default pattern export options #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmuenzenmeyer merged 1 commit into from
Oct 29, 2019
Merged

feat(config): add new default pattern export options #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/patternlab-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,11 @@
},
"patternExtension": "mustache",
"patternStateCascade": ["inprogress", "inreview", "complete"],
"patternExportDirectory": "./pattern_exports/",
"patternExportAll": false,
"patternExportDirectory": "pattern_exports",
"patternExportPatternPartials": [],
"patternExportPreserveDirectoryStructure": true,
Copy link
Contributor

@sghoweri sghoweri Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOAH - really?! 🎉

Copy link
Member Author

@bmuenzenmeyer bmuenzenmeyer Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looked a bit scary to me, but it works in my initial testing, and currently only does the top-level.

the OP mentioned this is a bit of WIP, so it could be extended for sure

"patternExportRaw": false,
"serverOptions": {
"wait": 1000
},
Expand Down
3 changes: 3 additions & 0 deletions packages/development-edition-engine-handlebars/patternlab-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,11 @@
},
"patternExtension": "hbs",
"patternStateCascade": ["inprogress", "inreview", "complete"],
"patternExportAll": false,
"patternExportDirectory": "pattern_exports",
"patternExportPatternPartials": [],
"patternExportPreserveDirectoryStructure": true,
"patternExportRaw": false,
"serverOptions": {
"wait": 1000
},
Expand Down
5 changes: 4 additions & 1 deletion packages/edition-node-gulp/patternlab-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,11 @@
},
"patternExtension": "mustache",
"patternStateCascade": ["inprogress", "inreview", "complete"],
"patternExportDirectory": "./pattern_exports/",
"patternExportAll": false,
"patternExportDirectory": "pattern_exports",
"patternExportPatternPartials": [],
"patternExportPreserveDirectoryStructure": true,
"patternExportRaw": false,
"serverOptions": {
"wait": 1000
},
Expand Down
5 changes: 4 additions & 1 deletion packages/edition-node/patternlab-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,11 @@
},
"patternExtension": "hbs",
"patternStateCascade": ["inprogress", "inreview", "complete"],
"patternExportDirectory": "./pattern_exports/",
"patternExportAll": false,
"patternExportDirectory": "pattern_exports",
"patternExportPatternPartials": [],
"patternExportPreserveDirectoryStructure": true,
"patternExportRaw": false,
"serverOptions": {
"wait": 1000
},
Expand Down
5 changes: 4 additions & 1 deletion packages/edition-twig/patternlab-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,11 @@
"inreview",
"complete"
],
"patternExportDirectory": "./pattern_exports/",
"patternExportAll": false,
"patternExportDirectory": "pattern_exports",
"patternExportPatternPartials": [],
"patternExportPreserveDirectoryStructure": true,
"patternExportRaw": false,
"serverOptions": {
"wait": 1000
},
Expand Down