Fix pattern lab create script #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@JosefBredereck @ringods what's the status on this one? Is there something holding this back from getting released or can we get this hotfix out the door ASAP? Asking for a friend (CC @bradfrost)! 😉 |
Contributor
Author
|
@sghoweri from my side its ready. |
Contributor
|
@JosefBredereck if this makes sure that If this fixes this, then all fine by me too. |
Contributor
Author
|
Yes exactly that it is doing. |
ringods
approved these changes
Nov 12, 2020
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While changes were made to the package resolving, some errors appeared. This should fix these errors.
Closes #1157
Closes #1247
Closes #1257
Summary of changes:
Updated execa
Added CWD to the installation of packages