Skip to content

refactor: fixed scrolling to annotations #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosefBredereck merged 9 commits into from
Jan 31, 2022
Merged

refactor: fixed scrolling to annotations #1417

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cb2102c
refactor: fixed scrolling behaviour and replaced plugin by native fun…
mfranzke Jan 30, 2022
a3522d1
refactor: removed the plugin / dependency
mfranzke Jan 30, 2022
795546f
chore: test for that method first of all
mfranzke Jan 30, 2022
0f7f4f3
chore: code reformatting
mfranzke Jan 30, 2022
600bd8d
Revert "chore: code reformatting"
mfranzke Jan 30, 2022
dd973aa
Revert "chore: test for that method first of all"
mfranzke Jan 30, 2022
e55dad6
Revert "refactor: removed the plugin / dependency"
mfranzke Jan 30, 2022
b85306a
Revert "refactor: fixed scrolling behaviour and replaced plugin by na…
mfranzke Jan 30, 2022
b3e6ac8
fix: removed the incorrect attribute
mfranzke Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/uikit-workshop/src/scripts/components/modal-viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export const modalViewer = {
if (i + 1 === pos) {
els[i].classList.add('pl-is-active');

scrollTo(patternInfoElem, document.body, {
scrollTo(patternInfoElem, {
top: els[i].offsetTop - 14,
behavior: 'smooth',
}).then(function () {
Expand Down