Skip to content

Conversation

@jeff-phillips-18
Copy link
Member

Change appropriate parameters to one-way bindings.

Change appropriate parameters to one-way bindings.
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Had one question about the use of the one-way binds around wizardReady and wizardDone.

loadingSecondaryInformation: '=?',
embedInPage: '=?',
wizardReady: '<?',
wizardDone: '<?',
Copy link
Member

@cdcabrera cdcabrera Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wizardReady and wizardDone do their status need to be piped back out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, these are just to inform the wizard of the app's status.

@cdcabrera cdcabrera merged commit a50b9be into patternfly:master Dec 8, 2017
@jeff-phillips-18 jeff-phillips-18 deleted the wizard branch March 13, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants