This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Require bootstrap v3.4.0 which resolves XSS #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jeff-phillips-18, @mcoker please review |
jeff-phillips-18
previously approved these changes
Dec 17, 2018
Contributor
Author
|
anyone ping. Can we get this merged and a new minor version of patternfly released to npm so it pulls the latest bootstrap that deals with the XSS issue ? |
Member
|
Please set the commit message format correctly for release. Use |
atodorov
force-pushed
the
update_bootstrap
branch
from
88fe618 to
ae65767
Compare
atodorov
force-pushed
the
update_bootstrap
branch
from
ae65767 to
1705d58
Compare
jeff-phillips-18
approved these changes
Dec 19, 2018
patternfly-build
pushed a commit
that referenced
this pull request
Dec 19, 2018
# [3.59.0](patternfly/patternfly@v3.58.0...v3.59.0) (2018-12-19) ### Features * **package:** Require bootstrap v3.4.0 to resolve XSS vulnerability ([#1157](patternfly/patternfly#1157)) ([fda70ed](patternfly/patternfly@fda70ed))
Contributor
|
🎉 This PR is included in version 3.59.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
10 tasks
Member
|
Umm, this caused inconsitencies between the gem and the npm package 😞 |
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Require the latest bootstrap v3.4.0 which resolves a cross-site scripting vulnerability, see
https://github.com/twbs/bootstrap/releases/tag/v3.4.0
Note: can you review and release a new npm version for folks who would like to update ASAP ?
Changes
PR checklist (if relevant)