Skip to content

Adding a trend card variation for values on the right#374

Merged
mcarrano merged 1 commit intopatternfly:masterfrom
beanh66:trend
Aug 24, 2017
Merged

Adding a trend card variation for values on the right#374
mcarrano merged 1 commit intopatternfly:masterfrom
beanh66:trend

Conversation

@beanh66
Copy link
Member

@beanh66 beanh66 commented Aug 21, 2017

Description

Changes

  • Adds an image to the overview showing this new variation
  • Adds an image to the design showing this new variation with callouts
  • Removes old unused images
  • Adds to the design description to note this variation.

Contribution Submission Checklist

  • A GitHub issue was created and reviewed with the PatternFly community.
  • The pattern design overview.md and design.md templates were used to provide all information, relevant to this design.
  • Any new files have been added to the folder for that pattern.
  • The folder, for brand new patterns, has been titled with the name of the pattern.
  • All images are in an "img" folder and embedded images have the correct filepath.
  • The overview.md and design.md, for this design have been commited and pushed to the patternfly-design repository, for review.

Copy link
Member

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @beanh66! Thanks for the quick work here!

@serenamarie125
Copy link
Member

Note that this fixes #366

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @beanh66 . Only one question. The Angular example on the site only has optin for value on the right. Is there an updated version of the example code that should be linked here?

@beanh66
Copy link
Member Author

beanh66 commented Aug 24, 2017

@mcarrano This PR includes the angular updates which @amarie401 has been working on to add the option for value on the right. The example shows radio button options for viewing either the value on the left or the right of the graph.

@mcarrano
Copy link
Member

Makes sense. Thanks for sharing the code example @beanh66 . I will go ahead and merge this one.

@mcarrano mcarrano merged commit a0f42b3 into patternfly:master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants