Skip to content

TabsController should not make assumptions about host's DOM #2695

@bennypowers

Description

@bennypowers

In TabsController's #rebuild() method:

const tabSlot = this.#element.shadowRoot?.querySelector<HTMLSlotElement>('slot[name=tab]');
const panelSlot = this.#element.shadowRoot?.querySelector<HTMLSlotElement>('slot:not([name])');

In order that tabs controller be applicable to any tabs implementation, these should be replaced with getter functions in the options.

We should also consider removing the dependency on expand / disabled events and the active property in a similar manner

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions