-
Notifications
You must be signed in to change notification settings - Fork 106
fix: CPFED-4017: a11y tab order primary detail #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
0173b8d
CPFED-4017:
kelsS a8d67c1
CPFED-4017:
kelsS 825f167
CPFED-4017
kelsS 569e1f5
CPFED-4017:
kelsS 5e08384
Branch was auto-updated with the latest.
github-actions[bot] f92ea3f
Branch was auto-updated with the latest.
github-actions[bot] d35fe2d
Branch was auto-updated with the latest.
github-actions[bot] a6ce04a
CPFED-4017:
kelsS add1fd8
CPFED-4017: added more updates based on feedback and added note to fi…
kelsS 3c188ff
Branch was auto-updated with the latest.
github-actions[bot] 4670400
CPFED-4017:
kelsS 2f694f9
CPFED-4017:
kelsS 0aa6d32
CPFED-4017:
kelsS f407fae
CPFED-4017: continued working on fixing bug
kelsS 4ef656e
CPFED-4017: commented out code to see if it was causing the build bug
kelsS eb6f436
CPFED-4017: removed accidental browsersync import that was caused by …
kelsS f4a3e18
Branch was auto-updated with the latest.
github-actions[bot] 4576751
Branch was auto-updated with the latest.
github-actions[bot] 05f2ff7
CPFED-4017: continued workin on tab order bug
kelsS a53d50b
Merge branch 'CPFED-4017-based-off-master' of github.com:patternfly/p…
kelsS 1b5e55d
Branch was auto-updated with the latest.
github-actions[bot] d653f8f
Branch was auto-updated with the latest.
github-actions[bot] 6193d5d
Branch was auto-updated with the latest.
github-actions[bot] 9b9bc74
CPFED-4017: continued workin on tab order bug
kelsS b3e181a
CPFED-4017: continued workin on tab order bug
kelsS 0ca0ef0
CPFED-4017: updated to use consistent-height attr on top one, moved f…
kelsS 4acd24e
CPFED-4017: updated to use consistent-height attr
kelsS ffe01d6
Branch was auto-updated with the latest.
github-actions[bot] 66210ef
CPFED-4017: added focus style class feature
kelsS 6c42636
Merge branch 'CPFED-4017-based-off-master' of github.com:patternfly/p…
kelsS 6096da2
CPFED-4017: added focus indicator readme info, removed lightdom style…
kelsS d2660e7
Branch was auto-updated with the latest.
github-actions[bot] 9a2b467
Merge branch 'master' into CPFED-4017-based-off-master
castastrophe 38c227f
Branch was auto-updated with the latest.
github-actions[bot] b6c6c88
Branch was auto-updated with the latest.
github-actions[bot] 0fc74d9
Branch was auto-updated with the latest.
github-actions[bot] d3b2f69
Branch was auto-updated with the latest.
github-actions[bot] 11a827a
Branch was auto-updated with the latest.
github-actions[bot] e03f50b
Branch was auto-updated with the latest.
github-actions[bot] dbd3df0
Branch was auto-updated with the latest.
github-actions[bot] 9f21150
Branch was auto-updated with the latest.
github-actions[bot] edab677
Branch was auto-updated with the latest.
github-actions[bot] d0e4bc5
Branch was auto-updated with the latest.
github-actions[bot] 6165b7b
Branch was auto-updated with the latest.
github-actions[bot] 1e285a4
Branch was auto-updated with the latest.
github-actions[bot] ed61c34
Branch was auto-updated with the latest.
github-actions[bot] afcee1f
Branch was auto-updated with the latest.
github-actions[bot] db68a06
Branch was auto-updated with the latest.
github-actions[bot] 7817dfd
Branch was auto-updated with the latest.
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| <div id="details-nav"> | ||
| <slot name="details-nav--header"></slot> | ||
| <slot name="details-nav"></slot> | ||
| <slot name="details-nav--footer"></slot> | ||
| </div> | ||
| <div id="details-wrapper"> | ||
| <slot name="details"></slot> | ||
| </div> | ||
| <slot name="details-nav--footer"></slot> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though great information, since this is now being managed by the component, I don't think we need to ask developers to add any styles anymore. I'd like to avoid requiring developers to write any custom styles in general so that we maintain a low-effort for implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the slotted content, we only address the nav part of this component, not what's in the pane. I think it's good to point out that just using our components doesn't get a site an A+ on a11y.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like great global advice that is not specific to this component then; would you like to find a good place to add it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also sounds like a place where pfe-base could offer assistance - is there anything missing in pfe-base styles to meet standards? If so, I'd like to get it included because ideally, you can get everything you need from the project and you have the option to write custom styles if you want to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds great! I think having a reminder that pane styles need to be accessible and a link to centralized docs would be 💯
@kelsS if you want to take a crack at pfe-base I'd like to do it as a separate ticket/PR/effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kelsS If you would like, I have a PR I just opened to add in the broadcasted variable hook to pfe-base.scss. If you find an update we can make to our base class (basically our version of normalize.css but a lot less opinionated), you're welcome to include it in this PR: https://github.com/patternfly/patternfly-elements/pull/1530/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme for pfe-styles is a great place to store notes on making your light DOM styles accessible and we can migrate these notes to the main documentation site after the migration.