Skip to content

Conversation

@wesruv
Copy link
Contributor

@wesruv wesruv commented Sep 3, 2021

Description of the issue

When an accordion is clicked in pfe-content-set there isn't enough information to tell what has been expanded/collapsed, making analytics based on interaction impossible.

Impacted component(s)

  • pfe-accordion
  • pfe-content-set

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

  • Added extra keys to details on accordion events to give analytics quick access to what element has opened/closed.

Testing instructions

  1. Go to https://www.redhat.com/en/contact
  2. In the console, add:
document.addEventListener('pfe-accordion:expand', function(event) {
  debugger;
});
  1. Click on an accordion to expand
  2. event.details Should have a reference to the toggle and pane that have updated

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Sep 3, 2021
@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 2e975a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/613b6d57bb580100089c5071

😎 Browse the preview: https://deploy-preview-1769--patternfly-elements.netlify.app

@github-actions github-actions bot added the AT passed Automated testing has passed label Sep 3, 2021
@wesruv wesruv changed the title WIP: 1764: Adding better details to accordion events fix: Adding better details to accordion events Sep 3, 2021
@wesruv wesruv added the ready: code review Ready for code review! label Sep 3, 2021
@github-actions github-actions bot added the tests Related to testing label Sep 10, 2021
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likable Gremlin Trotted Mindfully

@kylebuch8 kylebuch8 enabled auto-merge (squash) September 10, 2021 15:49
@kylebuch8 kylebuch8 merged commit e190e3b into master Sep 10, 2021
@kylebuch8 kylebuch8 deleted the 1764-add-more-details-to-tabs-and-accordions branch September 10, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready: code review Ready for code review! tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants