fix: issue-1781 Mobile typography variable names #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for patternfly-elements ready! 🔨 Explore the source changes: 175504d 🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/6143ba5471740f00079cae0a 😎 Browse the preview: https://deploy-preview-1782--patternfly-elements.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Fixes names of CSS variables in demo page
Related issues
Preview
https://deploy-preview-1782--patternfly-elements.netlify.app/elements/pfe-styles/demo/typography-mobile.html
http://localhost:8080/elements/pfe-styles/demo/typography-mobile.html
What has changed and why
CSS variables had too many dashes, so they weren't working. Now you can see the demo of responsive typography in action.
Testing instructions
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!