-
Notifications
You must be signed in to change notification settings - Fork 106
chore: update dependencies #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 61ab088 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
_To edit notification comments on pull requests, go to your Netlify site settings. |
|
On fresh install when loading label demo. Also primary-detail. Digging into to find why this is only on a couple of components. |
Correction primary detail looks to be a seperate issue with the demo/pfe-primary-detail.js: Commenting out line 7 and the demo seems to load correctly and the events seem to fire ok, not sure that line is needed. Update: |
|
lightdom.css also doesn't appear to be loading for the components that have it linked in their demos: Update: Update number 2:
|
|
Ran the tests locally and everything looked good from my end, all the components built and looked correct on their docs pages. @zeroedin - Can you confirm whether or not clearing node_modules & running npm run clean:nuke and then reinstalling helps clear some of those issues you were seeing? That's what I ran on mine and it built afterwards |
Yes ran it several times yesterday and just for brevity again after you asked: Here is what pfe-label demo looks like: Here is the error: This was after: |
1759fb7 to
63abb39
Compare
|
@zeroedin please check again |
|
@bennypowers |
|
@zeroedin let's do that in a new PR |


Updates many dependencies