Skip to content

feat(badge): add box-sizing property to match PF's badge #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marionnegp merged 11 commits into from
Nov 16, 2022
Merged

feat(badge): add box-sizing property to match PF's badge #2232

marionnegp merged 11 commits into from
Nov 16, 2022

Conversation

@marionnegp
Copy link
Contributor

@marionnegp marionnegp commented Nov 10, 2022 •
edited
Loading

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

  • Added box-sizing and display properties to match PF badge's properties

Testing instructions

  1. View badge demo page and compare to PatternFly's badge.

@marionnegp marionnegp self-assigned this Nov 10, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: fbb685e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review styles An issue or PR pertaining only to CSS/Sass AT passed Automated testing has passed labels Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit e91f835
😎 Deploy Preview https://deploy-preview-2232--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@marionnegp marionnegp linked an issue Nov 10, 2022 that may be closed by this pull request
[1:1]: pfe-badge: doesn't match PF's badge min-width visually #2231
Closed
@marionnegp marionnegp marked this pull request as ready for review November 10, 2022 16:58
brianferry
brianferry requested changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - this looks good to me, just had the one comment below and ready to merge.

brianferry
brianferry approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @marionnegp!

@marionnegp marionnegp merged commit 738eb8c into main Nov 16, 2022
@marionnegp marionnegp deleted the feat/pf-badge-1-1 branch November 16, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianferry brianferry brianferry approved these changes

Assignees

@marionnegp marionnegp

Labels

AT passed Automated testing has passed styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[1:1]: pfe-badge: doesn't match PF's badge min-width visually

3 participants

@marionnegp @brianferry