fix(core): resolves #2408 for roving-tabindex-controller #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2194a4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
reviewed
Mar 13, 2023
bennypowers
reviewed
Mar 16, 2023
bennypowers
reviewed
Mar 16, 2023
bennypowers
requested changes
Mar 16, 2023
Member
bennypowers
left a comment
bennypowers
left a comment
There was a problem hiding this comment.
we should save the state in hostDisconnected, or at least not destroy it in hostConnected, OR we should make it clear to users that this is how they need to hold it
Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
….com:patternfly/patternfly-elements into fix/roving-tabindex-controller/aria-expanded
.bind() creates a new object on each call, so we can't use it to removeEventListener. Also makes the itemsContainer default to the host at each initItems call
bennypowers
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
roving-tabindex-controller'sinitItems()to limitkeydownlistener to a specific container element instead of hostaria-expanded=truefromhorizontalyOnlykeyboard navigationTesting Instructions
Since this is a controller, the way I had to test it was to temporarily do the following:
roving-tabindex-controller.jstopf-tabsandpf-jumplinkselement folders.pf-tabs/BaseTabs.jsandpf-jumplinks/pf-jumplinks.jsto./roving-tabindex-controller.js.